[Bigbang-dev] What haven't you merge my pull request?

Sebastian Benthall sb at ischool.berkeley.edu
Mon Aug 15 17:05:17 PDT 2016


I've fixed the tests and merged these pull requests.

Thanks so much Niels and Harsh for your contributions!

On Mon, Aug 8, 2016 at 12:40 PM, Sebastian Benthall <sb at ischool.berkeley.edu
> wrote:

> Good news: the failing tests aren't due to anything in your Pull Requests.
>
> Bad news: the failing tests look like they are due to changes in the
> Pandas API.
>
> I will figure out how to fix these failing tests before continuing to
> merge in these pull requests and the work from the workshop.
>
> On Mon, Aug 8, 2016 at 11:47 AM, Sebastian Benthall <
> sb at ischool.berkeley.edu> wrote:
>
>> You'll see that there are several pull requests that I haven't yet merged
>> in:
>>
>> https://github.com/sbenthall/bigbang/pull/259
>> https://github.com/sbenthall/bigbang/pull/258
>> https://github.com/sbenthall/bigbang/pull/253
>>
>> Thanks so much for these contributions!
>>
>> The reason why I haven't pulled them in is because there are *failing
>> tests* associated with these pull request.
>>
>> We are using the continuous integration
>> <https://en.wikipedia.org/wiki/Continuous_integration> system Travis CI
>> <https://travis-ci.org/> for BigBang (thanks to the thoughtful
>> contribution of Spiros Eliopoulos). This runs the automated test suite
>> against the source code for any pull request and alerts us to anything that
>> may be going wrong.
>>
>> I'll be looking at these pull requests and seeing what's up with the
>> failing tests.
>>
>> Cheers,
>> Seb
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://sudoroom.org/pipermail/bigbang-dev/attachments/20160815/df93b4ff/attachment.html>


More information about the BigBang-dev mailing list